<div>This is great and will undoubtedly be very useful. I really like the idea. What worries me is that the configuration is centralized, so I can imagine users forgetting to set up this and then code that relies on this breaking - and people opening up support tickets :)</div>
<div><br></div><div>It would be extra nice if you could set this up when you establish an AMI connection, maybe with a mask, something like:</div><div><br></div><div>SIP/2: OWNER, PEER</div><div>SIP/3: OWNER, PEER, ABCD</div>
<div>*: PEER</div><div><br></div><div>This would basically mean that we want to see PEER for each channel, we want OWNER as well for channels that start with SIP/2, and ABCD for SIP/3.</div><div><br></div><div>I can also imagine hardcoding GetVars to help in case such variables don't come automatically, so this just wants to be some input :)</div>
<div>l.</div><div><br></div><br><div class="gmail_quote">2009/9/17 Tilghman Lesher <span dir="ltr"><<a href="mailto:tlesher@digium.com">tlesher@digium.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im"><br>
-----------------------------------------------------------<br>
This is an automatically generated e-mail. To reply, visit:<br>
<a href="https://reviewboard.asterisk.org/r/368/" target="_blank">https://reviewboard.asterisk.org/r/368/</a><br>
-----------------------------------------------------------<br>
<br>
</div>(Updated 2009-09-16 20:09:33.517920)<br>
<div class="im"><br>
<br>
Review request for Asterisk Developers.<br>
<br>
<br>
</div>Changes<br>
-------<br>
<br>
Provide an example of output.<br>
<br>
<br>
Summary (updated)<br>
<div class="im">-------<br>
<br>
The intent of this patch is to post various variables from a related channel, when posting certain call-related events to the manager interface.<br>
<br>
</div>For example, the following manager.conf entry:<br>
<br>
channelvars=SV_OWNER,SV_PEER,DISPLAY_URL<br>
<br>
will result in the following manager output for a Newstate event:<br>
<br>
Event: Newstate<br>
Privilege: call,all<br>
Channel: SIP/200-08b75888<br>
State: Up<br>
CallerID: 200<br>
CallerIDName: Snom Phone<br>
Uniqueid: 1209084781.0<br>
Channel1Var-SV_OWNER: a1101<br>
Channel1Var-SV_PEER: a1116<br>
Channel1Var-DISPLAY_URL:<br>
<br>
For Link events, you'll also see Channel2Var-type entries for the<br>
corresponding bridged channel.<br>
<div><div class="h5"><br>
<br>
Diffs<br>
-----<br>
<br>
/trunk/apps/app_chanspy.c 219006<br>
/trunk/apps/app_dial.c 219006<br>
/trunk/apps/app_fax.c 219006<br>
/trunk/apps/app_meetme.c 219006<br>
/trunk/apps/app_minivm.c 219006<br>
/trunk/apps/app_queue.c 219006<br>
/trunk/apps/app_voicemail.c 219006<br>
/trunk/channels/chan_iax2.c 219006<br>
/trunk/channels/chan_sip.c 219006<br>
/trunk/configs/manager.conf.sample 219006<br>
/trunk/include/asterisk/manager.h 219006<br>
/trunk/main/cdr.c 219006<br>
/trunk/main/channel.c 219006<br>
/trunk/main/features.c 219006<br>
/trunk/main/manager.c 219006<br>
/trunk/res/res_monitor.c 219006<br>
/trunk/res/res_musiconhold.c 219006<br>
<br>
Diff: <a href="https://reviewboard.asterisk.org/r/368/diff" target="_blank">https://reviewboard.asterisk.org/r/368/diff</a><br>
<br>
<br>
Testing<br>
-------<br>
<br>
It compiles! Ship it!<br>
<br>
<br>
Thanks,<br>
<br>
Tilghman<br>
<br>
<br>
_______________________________________________<br>
--Bandwidth and Colocation Provided by <a href="http://www.api-digital.com--" target="_blank">http://www.api-digital.com--</a><br>
<br>
AstriCon 2009 - October 13 - 15 Phoenix, Arizona<br>
Register Now: <a href="http://www.astricon.net" target="_blank">http://www.astricon.net</a><br>
<br>
asterisk-dev mailing list<br>
To UNSUBSCRIBE or update options visit:<br>
<a href="http://lists.digium.com/mailman/listinfo/asterisk-dev" target="_blank">http://lists.digium.com/mailman/listinfo/asterisk-dev</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>Loway - home of QueueMetrics - <a href="http://queuemetrics.com">http://queuemetrics.com</a><br><br>