[asterisk-dev] [Code Review] Add Calling and Called subaddress support for Asterisk apps and funcs

[rmudgett at digium.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/405/#review1193
-----------------------------------------------------------

Ship it!


Fix this last item and it looks ready.  Post your final patch files in the mantis issue and I'll get them committed.


/team/rmudgett/subaddr/channels/sig_pri.c
<https://reviewboard.asterisk.org/r/405/#comment2772>

    The ast_log() is not necessary and should be removed.  The ast_malloc() has already griped about the failed allocation.
    
    Coding guidelines do not allow mixing code and variable declarations.
    
    Also trim the trailing whitespace.


- rmudgett


On 2009-10-19 16:12:35, Alec Davis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/405/
> -----------------------------------------------------------
> 
> (Updated 2009-10-19 16:12:35)
> 
> 
> Review request for Asterisk Developers, rmudgett and mattf.
> 
> 
> Summary
> -------
> 
> Add dialstring support for called subaddress, used like Dial(dahdi/g0/5551234:8512) where 5551234 is the main line number of the remote site and 8512 is the extension with that site.
> If 'User Specific' BCD encoding is required, the subaddress is prefixed with a 'U'. IE Dial(dahdi/g0/5551234:U8512)
> 
> Extend function CALLERID() for type 'subaddr' to allow reading and updating the calling subaddress.
> Extend function CALLERID() for type 'dnid-subaddr' to allow reading and updating the called subaddress.
> Extend function CONNECTEDLINE as for CALLERID
> 
> 
> This addresses bug 15604.
>     https://issues.asterisk.org/view.php?id=15604
> 
> 
> Diffs
> -----
> 
>   /team/rmudgett/subaddr/channels/sig_pri.c 224402 
>   /team/rmudgett/subaddr/funcs/func_callerid.c 224402 
>   /team/rmudgett/subaddr/funcs/func_connectedline.c 224402 
>   /team/rmudgett/subaddr/include/asterisk/channel.h 224402 
>   /team/rmudgett/subaddr/main/channel.c 224402 
> 
> Diff: https://reviewboard.asterisk.org/r/405/diff
> 
> 
> Testing
> -------
> 
> Preliminary concept testing between sites over Telecom NZ PSTN, using channel variables $CALLINGSUBADDR and $CALLEDSUBADDR with patches for branches at https://issues.asterisk.org/view.php?id=15604 
> Development and testing using Jtec 5015 switches, establish calls in either direction, NSAP and User Specific.
> 
> 
> Thanks,
> 
> Alec
> 
>