[asterisk-dev] [Code Review] Add Calling and Called subaddress support for Asterisk apps and funcs

[Alec Davis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/405/
-----------------------------------------------------------

(Updated 2009-10-19 16:12:35.419433)


Review request for Asterisk Developers, rmudgett and mattf.


Changes
-------

Changes as required.

In main/channel.c:ast_party_subaddress_init should we be freeing the possible allocated memory, instead of just setting it to NULL?

init->str = NULL;
becomes
if (init->str)
  ast_free(dest->str);


Summary
-------

Add dialstring support for called subaddress, used like Dial(dahdi/g0/5551234:8512) where 5551234 is the main line number of the remote site and 8512 is the extension with that site.
If 'User Specific' BCD encoding is required, the subaddress is prefixed with a 'U'. IE Dial(dahdi/g0/5551234:U8512)

Extend function CALLERID() for type 'subaddr' to allow reading and updating the calling subaddress.
Extend function CALLERID() for type 'dnid-subaddr' to allow reading and updating the called subaddress.
Extend function CONNECTEDLINE as for CALLERID


This addresses bug 15604.
    https://issues.asterisk.org/view.php?id=15604


Diffs (updated)
-----

  /team/rmudgett/subaddr/channels/sig_pri.c 224402 
  /team/rmudgett/subaddr/funcs/func_callerid.c 224402 
  /team/rmudgett/subaddr/funcs/func_connectedline.c 224402 
  /team/rmudgett/subaddr/include/asterisk/channel.h 224402 
  /team/rmudgett/subaddr/main/channel.c 224402 

Diff: https://reviewboard.asterisk.org/r/405/diff


Testing
-------

Preliminary concept testing between sites over Telecom NZ PSTN, using channel variables $CALLINGSUBADDR and $CALLEDSUBADDR with patches for branches at https://issues.asterisk.org/view.php?id=15604 
Development and testing using Jtec 5015 switches, establish calls in either direction, NSAP and User Specific.


Thanks,

Alec