[asterisk-dev] [Code Review] better SDP parsing algorithm for 1.4

Matthew Nicholson mnicholson at digium.com
Fri Oct 2 07:44:36 CDT 2009

This is an automatically generated e-mail. To reply, visit:

(Updated 2009-10-02 07:44:36.242009)

Review request for Asterisk Developers, Olle E Johansson and Matthew Nicholson.


Added asterisk-dev group and oej to the review request.


This patch cleans up asterisk's SDP parsing algorithm, resolving a few bugs including #14994. It does the parsing line by line, making a distinction between session-level and media-specific parameters. It also optimizes the parsing adding functions for audio/video/image specific scanning.
I added debug information for a better understanding on how the parsing is actually done (shows each SDP line parsed with OK or UNSUPPORTED).

If ported to 1.6 (sorry but I have no idea how the SIP code changed between 1.4 and 1.6 so I don't know how to do it), it will allow to easily add SDP functionality.

This addresses bug 0014994.


  branches/1.4/channels/chan_sip.c 221961 

Diff: https://reviewboard.asterisk.org/r/385/diff


Production tested for multiple audio and video devices in a version of the patch for (see bug #14994).

Not tested with T.38, but it should work well.



More information about the asterisk-dev mailing list