[asterisk-dev] [Code Review] data api gsoc2009

[Tilghman Lesher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/275/#review1251
-----------------------------------------------------------


Other than these few changes, I think we're otherwise ready for this to be merged into trunk.


/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/275/#comment2904>

    I agree with Russell that we probably shouldn't change the internals of app_queue.  It's a nice demonstration of the idea, but I don't think it will go into trunk.



/trunk/apps/app_voicemail.c
<https://reviewboard.asterisk.org/r/275/#comment2905>

    We'll need some documentation to be written stating how to create the data export routines for each of the individual modules, so that this can be reasonably created as a janitor project.


- Tilghman


On 2009-08-17 13:18:14, Eliel Sardañons wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/275/
> -----------------------------------------------------------
> 
> (Updated 2009-08-17 13:18:14)
> 
> 
> Review request for Asterisk Developers, Russell Bryant and Tilghman Lesher.
> 
> 
> Summary
> -------
> 
> This is the first review request for the Data API GSoC 2009 project.
> An architectural review is requested.
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 212504 
>   /trunk/apps/app_queue.c 212504 
>   /trunk/apps/app_voicemail.c 212504 
>   /trunk/doc/manager_1_1.txt 212504 
>   /trunk/include/asterisk/_private.h 212504 
>   /trunk/include/asterisk/channel.h 212504 
>   /trunk/include/asterisk/data.h PRE-CREATION 
>   /trunk/include/asterisk/doxyref.h 212504 
>   /trunk/include/asterisk/xml.h 212504 
>   /trunk/main/asterisk.c 212504 
>   /trunk/main/channel.c 212504 
>   /trunk/main/data.c PRE-CREATION 
>   /trunk/main/xml.c 212504 
>   /trunk/tests/test_data.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/275/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eliel
> 
>