[asterisk-dev] [Code Review] hints with 2+ devices that include ONHOLD

[Philippe Lindheimer]

Thanks for the review and the issue already pointed out. It brought up additional issues so I have attached two new patches for 1.4 and trunk. I made the following comment in the ticket: https://issues.asterisk.org/view.php?id=15057

TICKET COMMENT:

There were some issues pointed out in the review which uncovered some
more in further testing, so attaching two new patches that should now
exhibit the following behavior:



BUSY & ONHOLD => BUSY

INUSE & ONHOLD => INUSE

ONHOLD & RINGING => RINGINUSE



this opens up a question, should the last return RINGINUSE or is a new
state required to return RINGONHOLD? (and if we have
ONHOLD&RINGING&INUSE do we return all three?)



My opinion would be RINGINUSE is appropriate...	



Message: 1
Date: Tue, 26 May 2009 17:55:57 -0000
From: "David Vossel" <dvossel at digium.com>
Subject: [asterisk-dev] [Code Review] hints with 2+ devices that
    include    ONHOLD
To: "David Vossel" <dvossel at digium.com>,    "Asterisk Developers"
    <asterisk-dev at lists.digium.com>
Message-ID: <20090526175557.7403.22626 at hotblack.digium.internal>
Content-Type: text/plain; charset="utf-8"


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/254/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

This is a community patch I cleaned up and tested.  Below is the reporter's, p_lidheimer, description of the issue pulled directly from issue #15057.

----------------------------
If you have a hint with two (or more) devices or a device and a custom devstate that includes ONHOLD, you get unexpected results. Two examples:

exten => 222,hint,SIP/222&SIP/211
exten => 333,hint,Custom:DND333&SIP/333

The following results are inconsistent as they should all return ONHOLD:

ONHOLD & IDLE = IDLE
ONHOLD & UNAVAILABLE => UNAVAILABLE
ONHOLD & UNKNOWN => IDLE
ONHOLD & INVALID => IDLE

Per Russell Bryant's response on the mailing list:

"I would agree that this is a bug. I would expect that combination of
states to result in an OnHold state."


This addresses bug 15057.
    https://issues.asterisk.org/view.php?id=15057


Diffs
-----

  /trunk/include/asterisk/devicestate.h 196415 
  /trunk/main/devicestate.c 196415 

Diff: http://reviewboard.digium.com/r/254/diff


Testing
-------

I have tested the patch and can verify the situations in the description all result in ONHOLD.


Thanks,

David




*****************************



      
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20090527/65a87e20/attachment.htm