<table cellspacing="0" cellpadding="0" border="0" ><tr><td valign="top" style="font: inherit;">Thanks for the review and the issue already pointed out. It brought up additional issues so I have attached two new patches for 1.4 and trunk. I made the following comment in the ticket: https://issues.asterisk.org/view.php?id=15057<br><br>TICKET COMMENT:<br><br>There were some issues pointed out in the review which uncovered some
more in further testing, so attaching two new patches that should now
exhibit the following behavior:<br>
<br>
BUSY & ONHOLD => BUSY<br>
INUSE & ONHOLD => INUSE<br>
ONHOLD & RINGING => RINGINUSE<br>
<br>
this opens up a question, should the last return RINGINUSE or is a new
state required to return RINGONHOLD? (and if we have
ONHOLD&RINGING&INUSE do we return all three?)<br>
<br>
My opinion would be RINGINUSE is appropriate... <br><br><blockquote style="border-left: 2px solid rgb(16, 16, 255); margin-left: 5px; padding-left: 5px;"><div class="plainMail"><br><br>Message: 1<br>Date: Tue, 26 May 2009 17:55:57 -0000<br>From: "David Vossel" <<a ymailto="mailto:dvossel@digium.com" href="/mc/compose?to=dvossel@digium.com">dvossel@digium.com</a>><br>Subject: [asterisk-dev] [Code Review] hints with 2+ devices that<br> include ONHOLD<br>To: "David Vossel" <<a ymailto="mailto:dvossel@digium.com" href="/mc/compose?to=dvossel@digium.com">dvossel@digium.com</a>>, "Asterisk Developers"<br> <<a ymailto="mailto:asterisk-dev@lists.digium.com" href="/mc/compose?to=asterisk-dev@lists.digium.com">asterisk-dev@lists.digium.com</a>><br>Message-ID: <<a ymailto="mailto:20090526175557.7403.22626@hotblack.digium.internal"
href="/mc/compose?to=20090526175557.7403.22626@hotblack.digium.internal">20090526175557.7403.22626@hotblack.digium.internal</a>><br>Content-Type: text/plain; charset="utf-8"<br><br><br>-----------------------------------------------------------<br>This is an automatically generated e-mail. To reply, visit:<br><a href="http://reviewboard.digium.com/r/254/" target="_blank">http://reviewboard.digium.com/r/254/</a><br>-----------------------------------------------------------<br><br>Review request for Asterisk Developers.<br><br><br>Summary<br>-------<br><br>This is a community patch I cleaned up and tested. Below is the reporter's, p_lidheimer, description of the issue pulled directly from issue #15057.<br><br>----------------------------<br>If you have a hint with two (or more) devices or a device and a custom devstate that includes ONHOLD, you get unexpected results. Two examples:<br><br>exten => 222,hint,SIP/222&SIP/211<br>exten =>
333,hint,Custom:DND333&SIP/333<br><br>The following results are inconsistent as they should all return ONHOLD:<br><br>ONHOLD & IDLE = IDLE<br>ONHOLD & UNAVAILABLE => UNAVAILABLE<br>ONHOLD & UNKNOWN => IDLE<br>ONHOLD & INVALID => IDLE<br><br>Per Russell Bryant's response on the mailing list:<br><br>"I would agree that this is a bug. I would expect that combination of<br>states to result in an OnHold state."<br><br><br>This addresses bug 15057.<br> <a href="https://issues.asterisk.org/view.php?id=15057" target="_blank">https://issues.asterisk.org/view.php?id=15057</a><br><br><br>Diffs<br>-----<br><br> /trunk/include/asterisk/devicestate.h 196415 <br> /trunk/main/devicestate.c 196415 <br><br>Diff: <a href="http://reviewboard.digium.com/r/254/diff" target="_blank">http://reviewboard.digium.com/r/254/diff</a><br><br><br>Testing<br>-------<br><br>I have tested the patch and can verify the situations in the
description all result in ONHOLD.<br><br><br>Thanks,<br><br>David<br><br><br><br><br>*****************************<br></div></blockquote></td></tr></table><br>