[asterisk-dev] [Code Review] Add 'bitflags' IE payload type to events framework
Russell Bryant
russell at digium.com
Sun May 3 04:01:06 CDT 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/242/#review764
-----------------------------------------------------------
Ship it!
Looks good
- Russell
On 2009-05-03 03:40:35, Kevin Fleming wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/242/
> -----------------------------------------------------------
>
> (Updated 2009-05-03 03:40:35)
>
>
> Review request for Asterisk Developers.
>
>
> Summary
> -------
>
> This adds a 'bitflags' IE payload type for events in the events framework; the payload is actually a 32-bit unsigned integer, but when matching payload values during subscription a bit-wise AND is used for the comparison instead of comparing the payload values.
>
>
> Diffs
> -----
>
> /trunk/include/asterisk/event.h 191883
> /trunk/include/asterisk/event_defs.h 191883
> /trunk/main/event.c 191883
>
> Diff: http://reviewboard.digium.com/r/242/diff
>
>
> Testing
> -------
>
> Compile testing only at this time.
>
>
> Thanks,
>
> Kevin
>
>
More information about the asterisk-dev
mailing list