[asterisk-dev] [Code Review] Add 'bitflags' IE payload type to events framework
Russell Bryant
russell at digium.com
Sat May 2 16:23:01 CDT 2009
> On 2009-05-02 10:51:42, Russell Bryant wrote:
> > Yeah, so, these should be switch statements so we know everything we have to change in the future. Sorry about that.
I have converted these places over to a switch statement, so they should be easy to find when you go to update the patch.
- Russell
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/242/#review761
-----------------------------------------------------------
On 2009-05-02 10:29:27, Kevin Fleming wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/242/
> -----------------------------------------------------------
>
> (Updated 2009-05-02 10:29:27)
>
>
> Review request for Asterisk Developers.
>
>
> Summary
> -------
>
> This adds a 'bitflags' IE payload type for events in the events framework; the payload is actually a 32-bit unsigned integer, but when matching payload values during subscription a bit-wise AND is used for the comparison instead of comparing the payload values.
>
>
> Diffs
> -----
>
> /trunk/main/event.c 191625
> /trunk/include/asterisk/event_defs.h 191625
> /trunk/include/asterisk/event.h 191625
>
> Diff: http://reviewboard.digium.com/r/242/diff
>
>
> Testing
> -------
>
> Compile testing only at this time.
>
>
> Thanks,
>
> Kevin
>
>
More information about the asterisk-dev
mailing list