[asterisk-dev] [Code Review] Add 'bitflags' IE payload type to events framework

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/242/#review761
-----------------------------------------------------------


Yeah, so, these should be switch statements so we know everything we have to change in the future.  Sorry about that.


/trunk/main/event.c
<http://reviewboard.digium.com/r/242/#comment1923>

    It needs to be added here.  If it was a switch statement, the compiler would have noted it.  Oops.



/trunk/main/event.c
<http://reviewboard.digium.com/r/242/#comment1924>

    We need to add it here, too.



/trunk/main/event.c
<http://reviewboard.digium.com/r/242/#comment1925>

    It should be added here, too.



/trunk/main/event.c
<http://reviewboard.digium.com/r/242/#comment1926>

    and here ..


- Russell


On 2009-05-02 10:29:27, Kevin Fleming wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/242/
> -----------------------------------------------------------
> 
> (Updated 2009-05-02 10:29:27)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This adds a 'bitflags' IE payload type for events in the events framework; the payload is actually a 32-bit unsigned integer, but when matching payload values during subscription a bit-wise AND is used for the comparison instead of comparing the payload values.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/event.c 191625 
>   /trunk/include/asterisk/event_defs.h 191625 
>   /trunk/include/asterisk/event.h 191625 
> 
> Diff: http://reviewboard.digium.com/r/242/diff
> 
> 
> Testing
> -------
> 
> Compile testing only at this time.
> 
> 
> Thanks,
> 
> Kevin
> 
>