[asterisk-dev] [Code Review] Optimizations to the stringfields API

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/165/#review648
-----------------------------------------------------------

Ship it!


This review certainly passes my scrutiny and it also passes the test that I submitted in a separate review request. Ship this puppy!

I'm going to withhold closing/merging the string field test until I've made it a bit more generic. Right now it is specifically testing the changes made here.

- Mark


On 2009-02-18 15:11:33, Kevin Fleming wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/165/
> -----------------------------------------------------------
> 
> (Updated 2009-02-18 15:11:33)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch provides a number of optimizations to the stringfields API, focused around saving (not wasting) memory whenever possible. Thanks to Mark Michelson for inspiring this work and coming up with the first two optimizations that are represented here:
> 
> Changes:
> 
> - Cleanup of some code, fix incorrect doxygen comments
> 
> - When a field is emptied or replaced with a new allocation, decrease the amount of 'active' space in the pool it was held in; if that pool reaches zero active space, and is not the current pool, then free it as it is no longer in use
> 
> - When allocating a pool, try to allocate a size that will fit in a 'standard' malloc() allocation without wasting space
> 
> - When allocating space for a field, store the amount of space in the two bytes immediately preceding the field; this eliminates the need to call strlen() on the field when overwriting it, and more importantly it 'remembers' the amount of space the field has available, even if a shorter string has been stored in it since it was allocated
> 
> - Don't automatically double the size of each successive pool allocated; it's wasteful
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/stringfields.h 177221 
>   /trunk/main/utils.c 177221 
> 
> Diff: http://reviewboard.digium.com/r/165/diff
> 
> 
> Testing
> -------
> 
> Tested with basic SIP calling between two phones that registered to Asterisk; no problems seen.
> 
> 
> Thanks,
> 
> Kevin
> 
>