[asterisk-dev] [Code Review] Merge Called party identification changes into trunk.

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/201/
-----------------------------------------------------------

(Updated 2009-03-17 16:59:54.517596)


Review request for Asterisk Developers.


Changes
-------

I realized that the newly-added func_connectedline.c and func_redirecting.c were not in the diff here.

I also added a note to CHANGES about chan_skinny supporting the transmission of remote party identification information. Thanks mvanbaak!


Summary
-------

This diff encompasses the changes between the issue8824 branch and Asterisk trunk. These changes include all the changes necessary to allow for the transmission and reception of remote called party identification (COLP/CONP).


This addresses bug 8824.
    http://bugs.digium.com/view.php?id=8824


Diffs (updated)
-----

  /trunk/apps/app_dial.c 182763 
  /trunk/CHANGES 182763 
  /trunk/apps/app_directed_pickup.c 182763 
  /trunk/apps/app_queue.c 182763 
  /trunk/channels/chan_agent.c 182763 
  /trunk/channels/chan_dahdi.c 182763 
  /trunk/channels/chan_h323.c 182763 
  /trunk/channels/chan_iax2.c 182763 
  /trunk/channels/chan_local.c 182763 
  /trunk/channels/chan_mgcp.c 182763 
  /trunk/channels/chan_misdn.c 182763 
  /trunk/channels/chan_phone.c 182763 
  /trunk/channels/chan_sip.c 182763 
  /trunk/channels/chan_skinny.c 182763 
  /trunk/channels/chan_unistim.c 182763 
  /trunk/channels/misdn/chan_misdn_config.h 182763 
  /trunk/channels/misdn/isdn_lib.h 182763 
  /trunk/channels/misdn/isdn_lib.c 182763 
  /trunk/channels/misdn/isdn_lib_intern.h 182763 
  /trunk/channels/misdn/isdn_msg_parser.c 182763 
  /trunk/channels/misdn_config.c 182763 
  /trunk/configs/misdn.conf.sample 182763 
  /trunk/configs/sip.conf.sample 182763 
  /trunk/funcs/func_connectedline.c PRE-CREATION 
  /trunk/funcs/func_redirecting.c PRE-CREATION 
  /trunk/include/asterisk/callerid.h 182763 
  /trunk/include/asterisk/channel.h 182763 
  /trunk/include/asterisk/frame.h 182763 
  /trunk/main/callerid.c 182763 
  /trunk/main/channel.c 182763 
  /trunk/main/dial.c 182763 
  /trunk/main/features.c 182763 
  /trunk/main/rtp.c 182763 

Diff: http://reviewboard.digium.com/r/201/diff


Testing
-------

Digium's Product Quality department has extensively tested a remarkably similar version of these enhancements. In addition, we know of a customer who has been using this branch for some months now in a production environment. I would also be willing to bet that some of those who have been monitoring issue 8824 have also done some testing as well.


Thanks,

Mark