[asterisk-dev] [Code Review] inotify(7) support for pbx_spool

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/137/#review564
-----------------------------------------------------------


I'm giving this a ping to see if you had done any testing of this yet, Tilghman. If so, my "Ship it!" still stands.

- Mark


On 2009-02-17 19:27:58, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/137/
> -----------------------------------------------------------
> 
> (Updated 2009-02-17 19:27:58)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Instead of scanning the directory and trying to keep tabs on the mtime of the directory, an approach which has already been shown to have an issue with directory entry races, use the kernel builtin method of inotify(7) to identify every file as it gets created in the spool directory.
> 
> 
> Diffs
> -----
> 
>   /trunk/configure 176770 
>   /trunk/configure.ac 176770 
>   /trunk/include/asterisk/autoconfig.h.in 176770 
>   /trunk/pbx/pbx_spool.c 176770 
> 
> Diff: http://reviewboard.digium.com/r/137/diff
> 
> 
> Testing
> -------
> 
> Compile-time testing only.
> 
> 
> Thanks,
> 
> Tilghman
> 
>