[asterisk-dev] [Code Review] Clean up func_odbc's dummy channel usage.
Matthew Nicholson
mnicholson at digium.com
Tue Jun 30 19:22:24 CDT 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/290/#review918
-----------------------------------------------------------
/trunk/funcs/func_odbc.c
<http://reviewboard.digium.com/r/290/#comment2218>
I don't understand what you mean here.
/trunk/funcs/func_odbc.c
<http://reviewboard.digium.com/r/290/#comment2219>
Same here.
/trunk/funcs/func_odbc.c
<http://reviewboard.digium.com/r/290/#comment2220>
I don't understand this one either.
- Matthew
On 2009-06-30 13:54:54, Matthew Nicholson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/290/
> -----------------------------------------------------------
>
> (Updated 2009-06-30 13:54:54)
>
>
> Review request for Asterisk Developers and Tilghman Lesher.
>
>
> Summary
> -------
>
> This patch cleans up func_odbc's use of dummy channels a bit. This is accomplished by releasing the dummy channel after we no longer need it and skipping sections of code that are pointless to execute without a channel.
>
>
> Diffs
> -----
>
> /trunk/funcs/func_odbc.c 204473
>
> Diff: http://reviewboard.digium.com/r/290/diff
>
>
> Testing
> -------
>
> None.
>
>
> Thanks,
>
> Matthew
>
>
More information about the asterisk-dev
mailing list