[asterisk-dev] [Code Review] Support for sending CDRs to syslogd

[Sean Bright]

> On 2009-06-26 13:12:00, Russell Bryant wrote:
> > /trunk/cdr/cdr_syslog.c, lines 130-135
> > <http://reviewboard.digium.com/r/297/diff/2/?file=5759#file5759line130>
> >
> >     What about supporting detection of when the config file hasn't changed?

There really aren't any resources that need to be acquired during configuration so right now we just blow away everything and load it up again on a reload request.  If you think we need to be smarter during reload I'll put something together.


- Sean


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/297/#review893
-----------------------------------------------------------


On 2009-06-26 12:13:56, Sean Bright wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/297/
> -----------------------------------------------------------
> 
> (Updated 2009-06-26 12:13:56)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This is the implementation of a CDR backend that allows sending CDR records to syslogd.
> 
> This patch was originally written by Brett Bryant and it was a modification to cdr_custom.  After some discussion I rewrote it as a separate module and added the ability to specify multiple logging destinations.  The setup instructions are included in the sample configuration file.
> 
> 
> This addresses bug 12876.
>     https://issues.asterisk.org/view.php?id=12876
> 
> 
> Diffs
> -----
> 
>   /trunk/build_tools/menuselect-deps.in 203669 
>   /trunk/cdr/cdr_syslog.c PRE-CREATION 
>   /trunk/configs/cdr_syslog.conf.sample PRE-CREATION 
>   /trunk/configure.ac 203669 
> 
> Diff: http://reviewboard.digium.com/r/297/diff
> 
> 
> Testing
> -------
> 
> Compiles.  Sent a few test calls through and they were logged successfully to multiple "sinks" defined in cdr_syslog.conf.
> 
> 
> Thanks,
> 
> Sean
> 
>