[asterisk-dev] [Code Review] Support for sending CDRs to syslogd

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/297/#review893
-----------------------------------------------------------

Ship it!


Just a few more minor suggestions.  Great job!


/trunk/cdr/cdr_syslog.c
<http://reviewboard.digium.com/r/297/#comment2154>

    What about supporting detection of when the config file hasn't changed?



/trunk/cdr/cdr_syslog.c
<http://reviewboard.digium.com/r/297/#comment2155>

    you could do ...
    
    return AST_RWLIST_EMPTY(&sinks) ? -1 : 0;



/trunk/cdr/cdr_syslog.c
<http://reviewboard.digium.com/r/297/#comment2156>

    You could do ... 
    
    return res ? AST_MODULE_LOAD_DECLINE : AST_MODULE_LOAD_SUCCESS;



/trunk/cdr/cdr_syslog.c
<http://reviewboard.digium.com/r/297/#comment2157>

    The module appears to be in the diff twice for some odd reason


- Russell


On 2009-06-26 12:13:56, Sean Bright wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/297/
> -----------------------------------------------------------
> 
> (Updated 2009-06-26 12:13:56)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This is the implementation of a CDR backend that allows sending CDR records to syslogd.
> 
> This patch was originally written by Brett Bryant and it was a modification to cdr_custom.  After some discussion I rewrote it as a separate module and added the ability to specify multiple logging destinations.  The setup instructions are included in the sample configuration file.
> 
> 
> This addresses bug 12876.
>     https://issues.asterisk.org/view.php?id=12876
> 
> 
> Diffs
> -----
> 
>   /trunk/build_tools/menuselect-deps.in 203669 
>   /trunk/cdr/cdr_syslog.c PRE-CREATION 
>   /trunk/configs/cdr_syslog.conf.sample PRE-CREATION 
>   /trunk/configure.ac 203669 
> 
> Diff: http://reviewboard.digium.com/r/297/diff
> 
> 
> Testing
> -------
> 
> Compiles.  Sent a few test calls through and they were logged successfully to multiple "sinks" defined in cdr_syslog.conf.
> 
> 
> Thanks,
> 
> Sean
> 
>