[asterisk-dev] [Code Review] 1.6 sip deadlock fix

[Matthew Nicholson]

> On 2009-06-19 12:48:59, Russell Bryant wrote:
> > /branches/1.6.2/channels/chan_sip.c, line 5788
> > <http://reviewboard.digium.com/r/287/diff/1/?file=5713#file5713line5788>
> >
> >     Is there a good reason to use usleep(1) instead of sched_yield()?

I don't know of any good reason.

This link has something to say about the subject:
http://www.technovelty.org/code/c/sched_yield.html

That does not fully apply here though.


- Matthew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/287/#review867
-----------------------------------------------------------


On 2009-06-19 12:39:08, Matthew Nicholson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/287/
> -----------------------------------------------------------
> 
> (Updated 2009-06-19 12:39:08)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This fixes a potential deadlock in the 1.6.2 branch.  This fix has been back ported from trunk.
> 
> 
> Diffs
> -----
> 
>   /branches/1.6.2/channels/chan_sip.c 198072 
> 
> Diff: http://reviewboard.digium.com/r/287/diff
> 
> 
> Testing
> -------
> 
> Tested with trunk.  No testing done for 1.6.2.
> 
> 
> Thanks,
> 
> Matthew
> 
>