[asterisk-dev] [Code Review] 1.6 sip deadlock fix

Russell Bryant russell at digium.com
Fri Jun 19 12:48:59 CDT 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/287/#review867
-----------------------------------------------------------

Ship it!


Other than this one comment, the changes look fine to me.


/branches/1.6.2/channels/chan_sip.c
<http://reviewboard.digium.com/r/287/#comment2118>

    Is there a good reason to use usleep(1) instead of sched_yield()?


- Russell


On 2009-06-19 12:39:08, Matthew Nicholson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/287/
> -----------------------------------------------------------
> 
> (Updated 2009-06-19 12:39:08)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This fixes a potential deadlock in the 1.6.2 branch.  This fix has been back ported from trunk.
> 
> 
> Diffs
> -----
> 
>   /branches/1.6.2/channels/chan_sip.c 198072 
> 
> Diff: http://reviewboard.digium.com/r/287/diff
> 
> 
> Testing
> -------
> 
> Tested with trunk.  No testing done for 1.6.2.
> 
> 
> Thanks,
> 
> Matthew
> 
>




More information about the asterisk-dev mailing list