[asterisk-dev] [svn-commits] mmichelson: trunk r201462 - /trunk/channels/chan_sip.c

[Russell Bryant]

SVN commits to the Digium repositories wrote:
> Author: mmichelson
> Date: Wed Jun 17 15:10:01 2009
> New Revision: 201462
> 
> URL: http://svn.asterisk.org/svn-view/asterisk?view=rev&rev=201462
> Log:
> Fix problem with no audio due to ignoring the SDP.
> 
> A recent change to our SDP version comparison made audio not function
> on some calls. This was because of a test wherein we were trying to
> see if an unsigned value was less than 0. This is a dumb comparison
> and arguably the compiler should have warned about it. Alas, though,
> it slipped past. Now it's fixed by changing the variable to be a
> signed type.
> 
> Found by several developers. Tested by mnicholson and dbrooks.

*cough* g++ would have caught it *cough*

;-)

-- 
Russell Bryant
Digium, Inc. | Engineering Manager, Open Source Software
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
Check us out at: www.digium.com & www.asterisk.org