[asterisk-dev] [Code Review] add initial support for AT+CUSD command

[Matthew Nicholson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/274/#review834
-----------------------------------------------------------



/trunk/channels/chan_mobile.c
<http://reviewboard.digium.com/r/274/#comment2042>

    I don't really like the way parsing is done here.  If there is a problem with a phone's implementation of the CUSD command, this routine won't fail gracefully.
    
    Make this handle errors better, or parse similar to the CLIP parser or one of the other message parsers.
    
    Also please move the actual parsing to a separate function that returns the response.



/trunk/channels/chan_mobile.c
<http://reviewboard.digium.com/r/274/#comment2040>

    Fix whitespace.



/trunk/channels/chan_mobile.c
<http://reviewboard.digium.com/r/274/#comment2041>

    whitespace


Other than that it looks good.

- Matthew


On 2009-06-06 03:12:28, Artem wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/274/
> -----------------------------------------------------------
> 
> (Updated 2009-06-06 03:12:28)
> 
> 
> Review request for Asterisk Developers and Matthew Nicholson.
> 
> 
> Summary
> -------
> 
> Hello,
> 
> this patch adds initial support for the AT+CUSD command.
> 
> Using this command it is possible to query the bilance of a prepaid card.
> 
> This patch adds a new CLI option: mobile cusd <deviceid> <command>
> 
> Example usage: mobile cusd K800i *101#
> 
> 
> This addresses bug 15278.
>     http://issues.asterisk.org/view.php?id=15278
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_mobile.c 946 
> 
> Diff: http://reviewboard.digium.com/r/274/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Artem
> 
>