[asterisk-dev] [Code Review] IAX timer not loading

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/262/
-----------------------------------------------------------

(Updated 2009-06-05 15:39:49.553487)


Review request for Asterisk Developers.


Changes
-------

updated fixing Russell's comments


Summary
-------

When loading chan_iax2, a timer is opened.  If this timer fails to open trunk peers/users may not be built correctly.  Depending on the order Asterisk loads modules, the timer may or may not be loaded before chan_iax2.  If it is not loaded before hand, trunk peers/users will not be set up even though a timing interface may be possible.  This patch waits until Asterisk is fully booted to create the timer.  If the timer fails, all trunked peers/users' IAX_TRUNK flags are cleared and a warning message appears.


This addresses bug 15191.
    https://issues.asterisk.org/view.php?id=15191


Diffs (updated)
-----

  /trunk/res/res_timing_timerfd.c 199276 
  /trunk/include/asterisk/module.h 199276 
  /trunk/main/loader.c 199276 

Diff: http://reviewboard.digium.com/r/262/diff


Testing
-------

tested with and without loading the timer module. worked correctly.


Thanks,

David