[asterisk-dev] [Code Review] IAX timer not loading

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/262/#review832
-----------------------------------------------------------



/trunk/include/asterisk/module.h
<http://reviewboard.digium.com/r/262/#comment2031>

    Instead of (2 << 0), use (1 << 1).



/trunk/main/loader.c
<http://reviewboard.digium.com/r/262/#comment2033>

    There is no need for this initialization.



/trunk/main/loader.c
<http://reviewboard.digium.com/r/262/#comment2034>

    I would write this as ...
    
    if (!load) {
        return FAILURE;
    }
    
    res = load();
    



/trunk/main/loader.c
<http://reviewboard.digium.com/r/262/#comment2032>

    Check for failure


- Russell


On 2009-06-05 15:12:05, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/262/
> -----------------------------------------------------------
> 
> (Updated 2009-06-05 15:12:05)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> When loading chan_iax2, a timer is opened.  If this timer fails to open trunk peers/users may not be built correctly.  Depending on the order Asterisk loads modules, the timer may or may not be loaded before chan_iax2.  If it is not loaded before hand, trunk peers/users will not be set up even though a timing interface may be possible.  This patch waits until Asterisk is fully booted to create the timer.  If the timer fails, all trunked peers/users' IAX_TRUNK flags are cleared and a warning message appears.
> 
> 
> This addresses bug 15191.
>     https://issues.asterisk.org/view.php?id=15191
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/module.h 199276 
>   /trunk/res/res_timing_timerfd.c 199276 
>   /trunk/main/loader.c 199276 
> 
> Diff: http://reviewboard.digium.com/r/262/diff
> 
> 
> Testing
> -------
> 
> tested with and without loading the timer module. worked correctly.
> 
> 
> Thanks,
> 
> David
> 
>