No subject
Sun Jul 19 19:54:31 CDT 2009
er,
which has the effect of properly numbering the calls in the display. We ca=
n then
react to the callnumber in on_hook events to clear the bit.
Any hints would be appreciate and I apologize for what seems to be a very b=
asic
question.
Dan
--_000_B59B72B1B1500C42BEB1374A84C366BD31E4210DECSJEXCHMBphoen_
Content-Type: text/html; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
<html xmlns:v=3D"urn:schemas-microsoft-com:vml" xmlns:o=3D"urn:schemas-micr=
osoft-com:office:office" xmlns:w=3D"urn:schemas-microsoft-com:office:word" =
xmlns:m=3D"http://schemas.microsoft.com/office/2004/12/omml" xmlns=3D"http:=
//www.w3.org/TR/REC-html40">
<head>
<meta http-equiv=3DContent-Type content=3D"text/html; charset=3Dus-ascii">
<meta name=3DGenerator content=3D"Microsoft Word 12 (filtered medium)">
<style>
<!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0in;
margin-right:0in;
margin-bottom:0in;
margin-left:.5in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:2045596200;
mso-list-type:hybrid;
mso-list-template-ids:-630538514 67698703 67698713 67698715 67698703 67698=
713 67698715 67698703 67698713 67698715;}
@list l0:level1
{mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
ol
{margin-bottom:0in;}
ul
{margin-bottom:0in;}
-->
</style>
<!--[if gte mso 9]><xml>
<o:shapedefaults v:ext=3D"edit" spidmax=3D"1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext=3D"edit">
<o:idmap v:ext=3D"edit" data=3D"1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang=3DEN-US link=3Dblue vlink=3Dpurple>
<div class=3DWordSection1>
<p class=3DMsoNormal>I have been looking at bugid 17680 and see a number of
issues-<o:p></o:p></p>
<p class=3DMsoNormal><o:p> </o:p></p>
<p class=3DMsoListParagraph style=3D'text-indent:-.25in;mso-list:l0 level1 =
lfo1'><![if !supportLists]><span
style=3D'mso-list:Ignore'>1.<span style=3D'font:7.0pt "Times New Roman"'>&n=
bsp;
</span></span><![endif]> Chan_skinny is calling ast_masq_park_call
assuming that ast_bridged_channel<br>
will actually return the remote channel. I am not sure why it does no=
t,<br>
but an easy fix would be to simply set a local variable to the result and<b=
r>
test it before calling ast_masq_park_call<o:p></o:p></p>
<p class=3DMsoListParagraph style=3D'text-indent:-.25in;mso-list:l0 level1 =
lfo1'><![if !supportLists]><span
style=3D'mso-list:Ignore'>2.<span style=3D'font:7.0pt "Times New Roman"'>&n=
bsp;
</span></span><![endif]>Chan_skinny is one of three channel drivers still u=
sing
ast_masq_Park_call, the<br>
rest seem to have a locally modified version of masq_park_call-<br>
see sip_park & sip_park_thread. Should chan_skinny follow that
template?<o:p></o:p></p>
<p class=3DMsoNormal><o:p> </o:p></p>
<p class=3DMsoNormal>My last question is sadly along the lines of C101, but=
I am
running out of reasonable<o:p></o:p></p>
<p class=3DMsoNormal>google queries to teach myself what I need to fix bug =
12324-<o:p></o:p></p>
<p class=3DMsoNormal><o:p> </o:p></p>
<p class=3DMsoNormal>A skinny device has reasonable number of active calls =
that
it can maintain at one time.<o:p></o:p></p>
<p class=3DMsoNormal>I believe that part of the issue with 12324 is that we=
do
not track the current call count,<o:p></o:p></p>
<p class=3DMsoNormal>nor convey it to the phone. The basic 7940 in Ca=
ll Manager
is identified as supporting<o:p></o:p></p>
<p class=3DMsoNormal>16 calls, so I am going to use that as a starting poin=
t for
my example.<o:p></o:p></p>
<p class=3DMsoNormal><o:p> </o:p></p>
<p class=3DMsoNormal>I would hate to assign a uint8_t[16] to the line struc=
ture
to track the call slots, as<o:p></o:p></p>
<p class=3DMsoNormal>It seems a waste of space. Would the following w=
ork
and be reasonable from<o:p></o:p></p>
<p class=3DMsoNormal>a space a performance standpoint.<o:p></o:p></p>
<p class=3DMsoNormal><o:p> </o:p></p>
<p class=3DMsoNormal>Add a uint16_t member to the device structure called
callnumber<o:p></o:p></p>
<p class=3DMsoNormal><o:p> </o:p></p>
<p class=3DMsoNormal>Track the calls with bitshifting (here’s where m=
y
googling is failing)<o:p></o:p></p>
<p class=3DMsoNormal><o:p> </o:p></p>
<p class=3DMsoNormal>for (int count=3D0; count < 16; count++) {<o:p></o:=
p></p>
<p class=3DMsoNormal> if (!(device->callnumber & 1<< cou=
nt)) {
<o:p></o:p></p>
<p class=3DMsoNormal> devic=
e->callnumber
^=3D 1<<count;<o:p></o:p></p>
<p class=3DMsoNormal> break=
;<o:p></o:p></p>
<p class=3DMsoNormal> }<o:p></o:p></p>
<p class=3DMsoNormal>}<o:p></o:p></p>
<p class=3DMsoNormal><o:p> </o:p></p>
<p class=3DMsoNormal>From here count can be used in transmit_call_info to
identify the call number,<o:p></o:p></p>
<p class=3DMsoNormal>which has the effect of properly numbering the calls i=
n the
display. We can then<o:p></o:p></p>
<p class=3DMsoNormal>react to the callnumber in on_hook events to clear the=
bit.<o:p></o:p></p>
<p class=3DMsoNormal><o:p> </o:p></p>
<p class=3DMsoNormal>Any hints would be appreciate and I apologize for what=
seems
to be a very basic<o:p></o:p></p>
<p class=3DMsoNormal>question.<o:p></o:p></p>
<p class=3DMsoNormal><o:p> </o:p></p>
<p class=3DMsoNormal>Dan<o:p></o:p></p>
<p class=3DMsoNormal><o:p> </o:p></p>
<p class=3DMsoNormal><o:p> </o:p></p>
<p class=3DMsoNormal><o:p> </o:p></p>
<p class=3DMsoNormal><o:p> </o:p></p>
</div>
</body>
</html>
--_000_B59B72B1B1500C42BEB1374A84C366BD31E4210DECSJEXCHMBphoen_--
More information about the asterisk-dev
mailing list