[asterisk-dev] [Code Review] Trunk implementation of fix for issue 12434
Mark Michelson
mmichelson at digium.com
Fri Jul 17 14:25:54 CDT 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/313/
-----------------------------------------------------------
Review request for Asterisk Developers.
Summary
-------
As the summary suggests, this is the trunk implementation of the fix for issue 12434. There is not much difference between this review request and https://reviewboard.asterisk.org/r/311/ . The two main differences are that trunk supports text streams, whereas 1.4 does not, and trunk will respond with a 0 port T.38 answer even with udptl_pt enabled if an accompanying audio stream is offered.
This addresses bug 12434.
https://issues.asterisk.org/view.php?id=12434
Diffs
-----
/trunk/channels/chan_sip.c 206453
Diff: https://reviewboard.asterisk.org/r/313/diff
Testing
-------
I used the same two sipp scenarios I used in review 311. I also set up a third scenario where audio and text were offered to be sure that the SDP response is appropriate.
Thanks,
Mark
More information about the asterisk-dev
mailing list