[asterisk-dev] [Code Review] Fixes 8khz assumptions
David Vossel
dvossel at digium.com
Wed Jul 8 15:47:18 CDT 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/306/
-----------------------------------------------------------
(Updated 2009-07-08 15:47:18.404619)
Review request for Asterisk Developers.
Changes
-------
This fixes Russell's comments and moves G722 samples/2 check into ast_rtp_raw_write()... Otherwise the check is only made if a smoother is present right before ast_rtp_raw_write().
Summary
-------
I've noticed several places in the code, especially chan_iax.c, where 8khz is assumed as the codec rate. This is not always the case. This patch only addresses chan_iax.c and res_rtp_asterisk.c, but I am sure there are other areas that make this assumption as well.
Diffs (updated)
-----
/trunk/channels/chan_iax2.c 205215
/trunk/include/asterisk/frame.h 205215
/trunk/res/res_rtp_asterisk.c 205215
Diff: http://reviewboard.digium.com/r/306/diff
Testing
-------
tested g722 call
Thanks,
David
More information about the asterisk-dev
mailing list