[asterisk-dev] [Code Review] Fixes 8khz assumptions

[David Vossel]

> On 2009-07-08 11:04:06, Russell Bryant wrote:
> > /trunk/res/res_rtp_asterisk.c, lines 2122-2123
> > <http://reviewboard.digium.com/r/306/diff/1/?file=5896#file5896line2122>
> >
> >     I'm not sure that you should use rtp_get_rate() here.  Inside of Asterisk, in ast_frame, we represent G.722 as 16 kHz.

You're right, I'll look over this a little closer to make sure I account for this special case correctly everywhere else as well.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/306/#review946
-----------------------------------------------------------


On 2009-07-07 17:31:54, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/306/
> -----------------------------------------------------------
> 
> (Updated 2009-07-07 17:31:54)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> I've noticed several places in the code, especially chan_iax.c, where 8khz is assumed as the codec rate.  This is not always the case.  This patch only addresses chan_iax.c and res_rtp_asterisk.c, but I am sure there are other areas that make this assumption as well.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_iax2.c 205114 
>   /trunk/include/asterisk/frame.h 205114 
>   /trunk/res/res_rtp_asterisk.c 205114 
> 
> Diff: http://reviewboard.digium.com/r/306/diff
> 
> 
> Testing
> -------
> 
> tested g722 call
> 
> 
> Thanks,
> 
> David
> 
>