[asterisk-dev] [Code Review] Timer.h, ast_samp2tv needs floating point for 16khz audio

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/305/#review947
-----------------------------------------------------------

Ship it!



/trunk/include/asterisk/time.h
<http://reviewboard.digium.com/r/305/#comment2262>

    space after cast.


- Russell


On 2009-07-07 12:29:39, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/305/
> -----------------------------------------------------------
> 
> (Updated 2009-07-07 12:29:39)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> In ast_samp2tv(), (1000000 / _rate) = 62.5 when _rate is 16000.  The .5 is currently stripped off because we don't calculate using floating points.  This causes madness with 16khz audio.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/time.h 204709 
> 
> Diff: http://reviewboard.digium.com/r/305/diff
> 
> 
> Testing
> -------
> 
> tested with g722, ast_samp2tv() returns correct timeval.
> 
> 
> Thanks,
> 
> David
> 
>