[asterisk-dev] [Code Review] Timer.h, ast_samp2tv needs floating point for 16khz audio
David Vossel
dvossel at digium.com
Tue Jul 7 12:29:39 CDT 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/305/
-----------------------------------------------------------
Review request for Asterisk Developers.
Summary
-------
In ast_samp2tv(), (1000000 / _rate) = 62.5 when _rate is 16000. The .5 is currently stripped off because we don't calculate using floating points. This causes madness with 16khz audio.
Diffs
-----
/trunk/include/asterisk/time.h 204709
Diff: http://reviewboard.digium.com/r/305/diff
Testing
-------
tested with g722, ast_samp2tv() returns correct timeval.
Thanks,
David
More information about the asterisk-dev
mailing list