[asterisk-dev] [Code Review] Keep bridge up if parking attempt fails

Jeff Peeler jpeeler at digium.com
Tue Jan 27 16:33:21 CST 2009

This is an automatically generated e-mail. To reply, visit:

(Updated 2009-01-27 16:33:21.008423)

Review request for Asterisk Developers.


I changed park_space_reserve to return the parkeduser rather than just the parking number. This allows the parkeduser to be placed in the parkinglot immediately thereby avoiding any possibility of another parking reserve request to take an already reserved space.


This corrects the unexpected behavior of having a bridged call drop just because of a failed parking attempt. Now, the bridge stays up if the parking attempt fails giving the user an opportunity to try again later or try another extension.

I pulled out the slot assignment functionality from park_call_full and put into park_space_reserve, enabling one to check and see if an attempt to enter the parking lot will succeed without doing so. The idea is to call park_space_reserve before doing any masquerades and bail out if the parking lot entry will fail.

The only thing I'm concerned about is if anywhere in park_call_full needs to be protected with the parkinglock.

This addresses bug 13494.

Diffs (updated)

  /branches/1.4/res/res_features.c 171694 

Diff: http://reviewboard.digium.com/r/133/diff


Tested cases with both attended and blind transfer to the park extension as well as with one touch parking.



More information about the asterisk-dev mailing list