[asterisk-dev] [Code Review] Add manager commands to list skinny device(s) and line(s)

[Michiel van Baak]

> On 2009-02-22 15:19:39, Russell Bryant wrote:
> > Other than a couple of minor style comments, this code looks fine.
> > 
> > Just make sure that you review the manager 1.1 documentation and see if you should be adding anything there.  Also, update the CHANGES file.  Finally, please review similar manager actions from other channel drivers and ensure that the header names and contents are as similar as possible in the cases that it makes sense.

I added the actions to the manager_1.1.txt
I renamed Name to ObjectName and I added ChannelObjectType headers. Also removed the spaces from headernames because I see all other modules dont use spaces in them.


> On 2009-02-22 15:19:39, Russell Bryant wrote:
> > trunk/channels/chan_skinny.c, lines 2950-2951
> > <http://reviewboard.digium.com/r/170/diff/1/?file=2824#file2824line2950>
> >
> >     This wouldn't compile under dev-mode :-)

It does here.
Why wouldn't it ?


> On 2009-02-22 15:19:39, Russell Bryant wrote:
> > trunk/channels/chan_skinny.c, lines 3155-3158
> > <http://reviewboard.digium.com/r/170/diff/1/?file=2824#file2824line3155>
> >
> >     You could just do this at the declaration of a.

nope.
The a[3] uses device which needs to be set first.
If we do this at declaration we get the error "'device' might be used uninitialized"


- Michiel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/170/#review471
-----------------------------------------------------------


On 2009-02-21 12:19:24, Michiel van Baak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/170/
> -----------------------------------------------------------
> 
> (Updated 2009-02-21 12:19:24)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Added 4 manager commands:
> SKINNYdevices
> SKINNYshowdevice
> SKINNYlines
> SKINNYshowlines
> 
> Inspired on chan_sips SIPpeers and SIPshowpeer
> 
> 
> This addresses bug 14521.
>     http://bugs.digium.com/view.php?id=14521
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_skinny.c 177975 
> 
> Diff: http://reviewboard.digium.com/r/170/diff
> 
> 
> Testing
> -------
> 
> Compiles under devmode on OpenBSD 4.5 amd64
> Runs good. CLI commands are not affected and the Manager output looks sane to me.
> 
> 
> Thanks,
> 
> Michiel
> 
>