[asterisk-dev] [Code Review] Add manager commands to list skinny device(s) and line(s)

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/170/#review471
-----------------------------------------------------------

Ship it!


Other than a couple of minor style comments, this code looks fine.

Just make sure that you review the manager 1.1 documentation and see if you should be adding anything there.  Also, update the CHANGES file.  Finally, please review similar manager actions from other channel drivers and ensure that the header names and contents are as similar as possible in the cases that it makes sense.


trunk/channels/chan_skinny.c
<http://reviewboard.digium.com/r/170/#comment1124>

    This wouldn't compile under dev-mode :-)



trunk/channels/chan_skinny.c
<http://reviewboard.digium.com/r/170/#comment1125>

    You could just do this at the declaration of a.


- Russell


On 2009-02-21 12:19:24, Michiel van Baak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/170/
> -----------------------------------------------------------
> 
> (Updated 2009-02-21 12:19:24)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Added 4 manager commands:
> SKINNYdevices
> SKINNYshowdevice
> SKINNYlines
> SKINNYshowlines
> 
> Inspired on chan_sips SIPpeers and SIPshowpeer
> 
> 
> This addresses bug 14521.
>     http://bugs.digium.com/view.php?id=14521
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_skinny.c 177975 
> 
> Diff: http://reviewboard.digium.com/r/170/diff
> 
> 
> Testing
> -------
> 
> Compiles under devmode on OpenBSD 4.5 amd64
> Runs good. CLI commands are not affected and the Manager output looks sane to me.
> 
> 
> Thanks,
> 
> Michiel
> 
>