[asterisk-dev] [Code Review] New queue CLI and Manager commands to facilitate fine-grained reloading

Mark Michelson mmichelson at digium.com
Thu Feb 12 16:18:28 CST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/115/
-----------------------------------------------------------

(Updated 2009-02-12 16:18:28.675293)


Review request for Asterisk Developers and Jared Smith.


Changes
-------

Fixed all the things Russell pointed out in his last round of comments.

I realized after reading Russell's comment about queue's membercount that it was modified very strangely during a reload, so I simplified it...a lot.


Summary
-------

The purpose of these changes is to add new CLI and manager commands in order to reload queues.

The new CLI commands are the "queue reload" and "queue reset stats" commands. The new manager commands
are the QueueReload QueueReset commands. Rather than explain them in detail here, I'll direct you to the
modified documentation in the code.

In order to easily facilitate these changes, I also revamped the backend functions. Now instead of having
one giant function to reload queues, there are multiple small ones.


Diffs (updated)
-----

  /trunk/CHANGES 175370 
  /trunk/apps/app_queue.c 175370 

Diff: http://reviewboard.digium.com/r/115/diff


Testing
-------

I ran many combinations of the CLI commands in succession, and a lesser number of the Manager commands. All appeared to do what is expected.


Thanks,

Mark




More information about the asterisk-dev mailing list