[asterisk-dev] [Code Review] New queue CLI and Manager commands to facilitate fine-grained reloading

[Mark Michelson]

> On 2009-02-12 15:42:48, Russell Bryant wrote:
> > /trunk/apps/app_queue.c, lines 5742-5756
> > <http://reviewboard.digium.com/r/115/diff/6/?file=2626#file2626line5742>
> >
> >     This function does not match the behavior of what it replaces.
> >     
> >     Specifically, you're decreasing the queue member count when the member is _not_ being removed.
> >     
> >     Also, this update of device state is not in the old code.  I'm not sure if this is an intended additional or not.

You're correct about the membercount portion of this being incorrect. I will be sure to fix this in my next upload.

Check a bit more closely and you'll see that the device state check was there before. However, I changed the argument to ast_device_state from what it was previously since it was incorrect. This is what is referred to in the Changes when I referred to the "small bug in member interface handling."


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/115/#review404
-----------------------------------------------------------


On 2009-02-11 16:09:40, Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/115/
> -----------------------------------------------------------
> 
> (Updated 2009-02-11 16:09:40)
> 
> 
> Review request for Asterisk Developers and Jared Smith.
> 
> 
> Summary
> -------
> 
> The purpose of these changes is to add new CLI and manager commands in order to reload queues.
> 
> The new CLI commands are the "queue reload" and "queue reset stats" commands. The new manager commands
> are the QueueReload QueueReset commands. Rather than explain them in detail here, I'll direct you to the
> modified documentation in the code.
> 
> In order to easily facilitate these changes, I also revamped the backend functions. Now instead of having
> one giant function to reload queues, there are multiple small ones.
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 174883 
>   /trunk/apps/app_queue.c 174883 
> 
> Diff: http://reviewboard.digium.com/r/115/diff
> 
> 
> Testing
> -------
> 
> I ran many combinations of the CLI commands in succession, and a lesser number of the Manager commands. All appeared to do what is expected.
> 
> 
> Thanks,
> 
> Mark
> 
>