[asterisk-dev] [Code Review] Limit addition of Contact header in SIP responses

[Olle E Johansson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/141/#review363
-----------------------------------------------------------

Ship it!


The code looks fine and is an improvement. I haven't checked the RFCs, but it seems like you've done the job. Thanks!

- Olle E


On 2009-02-05 15:44:50, Matthew Nicholson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/141/
> -----------------------------------------------------------
> 
> (Updated 2009-02-05 15:44:50)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch ensures that asterisk does not include the 'Contact' header in responses unless it is necessary (according to various SIP RFCs).
> 
> 
> This addresses bug 13602.
>     http://bugs.digium.com/view.php?id=13602
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/channels/chan_sip.c 165953 
> 
> Diff: http://reviewboard.digium.com/r/141/diff
> 
> 
> Testing
> -------
> 
> I lightly tested this with ekiga using the REGISTER, INVITE, SUBSCRIBE, and BYE methods.
> 
> 
> Thanks,
> 
> Matthew
> 
>