[asterisk-dev] [Code Review] [15609] Prevent a stream of warnings about the voice frame queue too long

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/452/#review1343
-----------------------------------------------------------

Ship it!


This looks good to me.  I'm still curious why in older versions, this warning never occurred.  Something changed ... but in any case, like I said, I think this is a good change to make.  Good riddance to this issue.

Nice work, Tilghman.

- Russell


On 2009-12-30 12:49:43, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/452/
> -----------------------------------------------------------
> 
> (Updated 2009-12-30 12:49:43)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> A long running issue is that in certain circumstances, a Local channel will start spewing "WARNING[23025]: channel.c:952 __ast_queue_frame: Exceptionally long voice queue length queuing to Local" messages, at the end of a call.
> 
> Basically, this patch realizes that if a channel does not have a thread running (i.e. a slave channel) and there is no bridge (no thread to copy frames from the slave channel), then queuing frames to that channel is completely useless and only causes messages to be spewed.
> 
> However, given the simplicity of the patch for a problem which has consumed a great many developer hours, I would like verification that this is the correct approach.
> 
> 
> This addresses bug 15609.
>     https://issues.asterisk.org/view.php?id=15609
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/channels/chan_local.c 236182 
> 
> Diff: https://reviewboard.asterisk.org/r/452/diff
> 
> 
> Testing
> -------
> 
> Verified that the patch fixes the problem for the reporter.
> 
> 
> Thanks,
> 
> Tilghman
> 
>