[asterisk-dev] [Code Review] Makefile now specifies whether or not DAHDI hardware was found

Russell Bryant russell at digium.com
Fri Apr 17 15:08:58 CDT 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/216/#review713
-----------------------------------------------------------



/tools/trunk/xpp/dahdi_hardware
<http://reviewboard.digium.com/r/216/#comment1846>

    You should probably put all of this in an if ($opts{'v'}) { } block, so that the else part is only printed out in verbose mode.


- Russell


On 2009-04-17 15:05:52, dbrooks wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/216/
> -----------------------------------------------------------
> 
> (Updated 2009-04-17 15:05:52)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This is a patch that allows the DAHDI Makefile to announce to the user whether or not it found DAHDI hardware. Prior to this patch, if DAHDI hardware was not found, "make config" would announce: "I think that the DAHDI hardware you have on your system is: " and stop there.
> 
> 
> This addresses bug 0014792.
>     http://bugs.digium.com/view.php?id=0014792
> 
> 
> Diffs
> -----
> 
>   /tools/trunk/Makefile 6374 
>   /tools/trunk/xpp/dahdi_hardware 6374 
> 
> Diff: http://reviewboard.digium.com/r/216/diff
> 
> 
> Testing
> -------
> 
> This patch was tested on x86_64-linux-gnu, and GNU Make 3.81.
> 
> 
> Thanks,
> 
> dbrooks
> 
>




More information about the asterisk-dev mailing list