[asterisk-dev] [asterisk-commits] mmichelson: trunk r151464 - /trunk/channels/chan_sip.c

[Kevin P. Fleming]

SVN commits to the Asterisk project wrote:
> Author: mmichelson
> Date: Tue Oct 21 18:54:41 2008
> New Revision: 151464
> 
> URL: http://svn.digium.com/view/asterisk?view=rev&rev=151464
> Log:
> Make the sip_standard_port function more granular by allowing separate
> type and port arguments. This is necessary because when building our From
> and Contact headers, we need to be absolutely sure that we are placing our
> source port there and not the peer's source port.

Unfortunately this is another area of breakage that we identified last
week (noted in OEJ's comments at the top of chan_sip.c in trunk). The
RFC mandates that we listen *on the same port* for UDP and TCP, period.
The 'tcpbindaddr' option is broken by definition and will need to be
replaced with a different configuration mechanism. I don't think the
changes you are making here will actually cover all the cases in the
current code, but the code is going to have to change anyway.

The only time the listening port will be different is for TLS, which is
an entirely different can of worms, but you've accounted for part of
that already.

-- 
Kevin P. Fleming
Director of Software Technologies
Digium, Inc. - "The Genuine Asterisk Experience" (TM)