[asterisk-dev] moh: datadir or varlibdir? [was: Re: [svn-commits] kpfleming: trunk r149917 - in /trunk: ./ configs/ res/]

[Tzafrir Cohen]

On Thu, Oct 16, 2008 at 08:30:33AM -0000, SVN commits to the Digium repositories wrote:
> Author: kpfleming
> Date: Thu Oct 16 03:30:32 2008
> New Revision: 149917
> 
> URL: http://svn.digium.com/view/asterisk?view=rev&rev=149917
> Log:
> support relative paths in musiconhold.conf, which makes moh work by default when Asterisk was configured using --prefix and 'make samples' is run
> 
> 
> Modified:
>     trunk/CHANGES
>     trunk/configs/musiconhold.conf.sample
>     trunk/res/res_musiconhold.c
> 
> Modified: trunk/CHANGES
> URL: http://svn.digium.com/view/asterisk/trunk/CHANGES?view=diff&rev=149917&r1=149916&r2=149917
> ==============================================================================
> --- trunk/CHANGES (original)
> +++ trunk/CHANGES Thu Oct 16 03:30:32 2008
> @@ -33,6 +33,8 @@
>     as previously used on the last "exten" line.  For example:
>       exten => 123,1,NoOp(something)
>       same  =>     n,SomethingElse()
> + * musiconhold.conf classes of type 'files' can now use relative directory paths,
> +   which are interpreted as relative to the astvarlibdir setting in asterisk.conf.

[snip]

Yes, this indeed makes configurations look nicer.

One thing, though: does the musiconhold belong under datadir or varlibdir?
I think that the same logic as applies as with the sounds directory:
this is mostly stuff you put at setup time.

-- 
               Tzafrir Cohen
icq#16849755              jabber:tzafrir.cohen at xorcom.com
+972-50-7952406           mailto:tzafrir.cohen at xorcom.com
http://www.xorcom.com  iax:guest at local.xorcom.com/tzafrir