[asterisk-dev] [Code Review] timerfd timing interface

Mark Michelson mmichelson at digium.com
Wed Nov 12 10:42:15 CST 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/52/
-----------------------------------------------------------

(Updated 2008-11-12 10:42:15.437700)


Review request for Asterisk Developers, Russell Bryant and Kevin Fleming.


Changes
-------

Let's see if this diff isn't a bit better. This should have all the ast_epr2 stuff removed as well as the configure script. It should also contain the res_timing_timerfd.c file.


Summary
-------

Starting with Linux Kernel version 2.6.25 and glibc version 2.8, there is a timing interface known as timerfd. This review request encompasses an Asterisk timing implementation using the timerfd interface.

Of particular note in this review request are all things related to menuselect and autoconf. If there's anything there that seems wrong or out of place, please don't hesitate to yell about it. Also, I'm not sure what all the changes to ast_expr2.[hc] are about, but if I've done something wrong with regards to those, please let me know how I can fix those too.


Diffs (updated)
-----

  trunk/trunk/build_tools/menuselect-deps.in 156159 
  trunk/trunk/configure.ac 156159 
  trunk/trunk/include/asterisk/autoconfig.h.in 156159 
  trunk/trunk/makeopts.in 156159 
  trunk/trunk/res/res_timing_timerfd.c PRE-CREATION 

Diff: http://reviewboard.digium.com/r/52/diff


Testing
-------

I have tested this by using the "timing test" CLI command and by doing some file playback.


Thanks,

Mark




More information about the asterisk-dev mailing list