[asterisk-dev] [Code Review] timerfd timing interface

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/52/#review126
-----------------------------------------------------------



trunk/autoconf/ast_c_compile_check.m4
<http://reviewboard.digium.com/r/52/#comment224>

    Be sure to commit this to trunk separately, since it's an unrelated bug fix.



trunk/configure
<http://reviewboard.digium.com/r/52/#comment225>

    In the next version of the patch, remove configure.  configure.ac is all that is needed for review.  



trunk/main/ast_expr2.h
<http://reviewboard.digium.com/r/52/#comment226>

    You have a couple of unrelated files with changes.  (Maybe it was a little out of sync with trunk)
    
    Also, the most important part, your new module, is missing from the diff.  :)


- Russell


On 2008-11-11 20:52:30, Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/52/
> -----------------------------------------------------------
> 
> (Updated 2008-11-11 20:52:30)
> 
> 
> Review request for Asterisk Developers, Russell Bryant and Kevin Fleming.
> 
> 
> Summary
> -------
> 
> Starting with Linux Kernel version 2.6.25 and glibc version 2.8, there is a timing interface known as timerfd. This review request encompasses an Asterisk timing implementation using the timerfd interface.
> 
> Of particular note in this review request are all things related to menuselect and autoconf. If there's anything there that seems wrong or out of place, please don't hesitate to yell about it. Also, I'm not sure what all the changes to ast_expr2.[hc] are about, but if I've done something wrong with regards to those, please let me know how I can fix those too.
> 
> 
> Diffs
> -----
> 
>   trunk/autoconf/ast_c_compile_check.m4 155862 
>   trunk/build_tools/menuselect-deps.in 155862 
>   trunk/configure 155862 
>   trunk/configure.ac 155862 
>   trunk/include/asterisk/autoconfig.h.in 155862 
>   trunk/main/ast_expr2.h 155862 
>   trunk/main/ast_expr2.c 155862 
>   trunk/makeopts.in 155862 
> 
> Diff: http://reviewboard.digium.com/r/52/diff
> 
> 
> Testing
> -------
> 
> I have tested this by using the "timing test" CLI command and by doing some file playback.
> 
> 
> Thanks,
> 
> Mark
> 
>