[asterisk-dev] [Code Review] Move the xml documentation API to another file.

Russell Bryant russell at digium.com
Mon Nov 10 07:39:16 CST 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/45/#review114
-----------------------------------------------------------

Ship it!


Looks fine :)

- Russell


On 2008-11-09 12:27:36, Eliel Sardañons wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/45/
> -----------------------------------------------------------
> 
> (Updated 2008-11-09 12:27:36)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Now that we are exporting an api to work on other places like res_agi (and not only pbx.c) we need to move this stuff to another file to make the code easier to understand. (Pointed by Russell)
> The files added are:
>   main/xmldoc.c
>   include/asterisk/xmldoc.h
> 
> we are exporting
> ast_xmldoc_build_synopsis()
> ast_xmldoc_build_syntax()
> ast_xmldoc_build_description()
> ast_xmldoc_build_seealso()
> ast_xmldoc_build_arguments()
> ast_xmldoc_printable()
> ast_xmldoc_load_documentation()
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/_private.h 155670 
>   /trunk/include/asterisk/term.h 155670 
>   /trunk/include/asterisk/xmldoc.h PRE-CREATION 
>   /trunk/main/Makefile 155670 
>   /trunk/main/asterisk.c 155670 
>   /trunk/main/pbx.c 155670 
>   /trunk/main/xmldoc.c PRE-CREATION 
> 
> Diff: http://reviewboard.digium.com/r/45/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eliel
> 
>




More information about the asterisk-dev mailing list