[asterisk-dev] [Code Review] Replace nested functions with file scope functions

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/33/#review112
-----------------------------------------------------------

Ship it!


Looks good, nice job!

- Russell


On 2008-11-07 17:07:06, Sean Bright wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/33/
> -----------------------------------------------------------
> 
> (Updated 2008-11-07 17:07:06)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This is a patch to promote the current nested functions in asterisk trunk to file level functions based on security concerns.  For more details, see:
> 
>   http://gcc.gnu.org/ml/gcc-help/2005-12/msg00174.html
> 
> Also, I added a note to one of the calls in main/features.c which I marked with an XXX comment.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_dial.c 155433 
>   /trunk/apps/app_directed_pickup.c 155433 
>   /trunk/apps/app_followme.c 155433 
>   /trunk/apps/app_queue.c 155433 
>   /trunk/channels/chan_sip.c 155433 
>   /trunk/include/asterisk/channel.h 155433 
>   /trunk/main/channel.c 155433 
>   /trunk/main/features.c 155433 
> 
> Diff: http://reviewboard.digium.com/r/33/diff
> 
> 
> Testing
> -------
> 
> This passes the 'make' test with dev-mode enabled, but I have not functionally tested extensively.
> 
> 
> Thanks,
> 
> Sean
> 
>