[asterisk-dev] [Code Review] Replace nested functions with file scope functions

[Sean Bright]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/33/
-----------------------------------------------------------

(Updated 2008-11-07 17:07:06.429606)


Review request for Asterisk Developers.


Changes
-------

Updated chan_sip ao2_callback to pass forcenamematch with the new ao2_callback_fn data pointer.


Summary
-------

This is a patch to promote the current nested functions in asterisk trunk to file level functions based on security concerns.  For more details, see:

  http://gcc.gnu.org/ml/gcc-help/2005-12/msg00174.html

Also, I added a note to one of the calls in main/features.c which I marked with an XXX comment.


Diffs (updated)
-----

  /trunk/apps/app_dial.c 155433 
  /trunk/apps/app_directed_pickup.c 155433 
  /trunk/apps/app_followme.c 155433 
  /trunk/apps/app_queue.c 155433 
  /trunk/channels/chan_sip.c 155433 
  /trunk/include/asterisk/channel.h 155433 
  /trunk/main/channel.c 155433 
  /trunk/main/features.c 155433 

Diff: http://reviewboard.digium.com/r/33/diff


Testing
-------

This passes the 'make' test with dev-mode enabled, but I have not functionally tested extensively.


Thanks,

Sean