[asterisk-dev] [asterisk-addons-commits] tilghman: trunk r688 - in /trunk: ./ channels/ configs/ res/

[Atis Lezdins]

On Fri, Nov 7, 2008 at 3:35 PM, Atis Lezdins <atis at iq-labs.net> wrote:
> Author: tilghman
> Date: Fri Nov  7 01:04:53 2008
> New Revision: 688
>
> URL: http://svn.digium.com/view/asterisk-addons?view=rev&rev=688
> Log:
> Revamp res_config_mysql to allow for multiple read/write handle configurations
> within realtime.
> (closes issue #13603)
>  Reported by: atis
>  Patch by: me
>
> Modified:
>    trunk/UPGRADE.txt
>    trunk/channels/chan_mobile.c
>    trunk/configs/res_mysql.conf.sample
>    trunk/res/res_config_mysql.c
>
> Modified: trunk/UPGRADE.txt
> URL: http://svn.digium.com/view/asterisk-addons/trunk/UPGRADE.txt?view=diff&rev=688&r1=687&r2=688
> ==============================================================================
> --- trunk/UPGRADE.txt (original)
> +++ trunk/UPGRADE.txt Fri Nov  7 01:04:53 2008
> @@ -1,3 +1,10 @@
> +res_config_mysql
> +================
> + - A greater variation of database handles has been made available, such that
> +   you can now configure realtime mysql to connect to multiple hosts and
> +   separate read queries from write queries.  Please familiarize yourself with
> +   the sample res_config_mysql.conf, as the new behavior is now
> specified there.
> +
>
> Tilghman, i see that you did a great job refactoring db connections in
> trunk, however this still doesn't fix issue 0013603.
>
> Database name within extconfig.conf has been around for long time
> (even in 1.2), but now it's broken in 1.6.0.
>
> So, some sort of minor patch should be applied to addons-1.6.0.
>
> Btw, is it ok that there was no "commit comment" in  0013603?
>
> Regards,
> Atis
>

Tilghman, i wonder why do you keep closing this issue. Don't you admit
that it's a regression?

As 1.6.1. has affected code refactored, there is probably no need for
fixing this, however it's an issue with 1.6.0 and I have uploaded a
patch long time ago. If necessary i can rewrite it in other way - so
that "database" is not shown in query.

Regards,
Atis



-- 
Atis Lezdins,
VoIP Project Manager / Developer,
atis at iq-labs.net
Skype: atis.lezdins
Cell Phone: +371 28806004
Cell Phone: +1 800 7300689
Work phone: +1 800 7502835