[asterisk-dev] [Code Review] Implement ast_channel_search_locked to expensive per-notify channel walk in chan_sip

Sean Bright sean.bright at gmail.com
Tue Nov 4 17:10:53 CST 2008

This is an automatically generated e-mail. To reply, visit:

(Updated 2008-11-04 17:10:53.177751)

Review request for Asterisk Developers.


Implement changes suggested by russellb.


Based on some feedback from my chan_sip commit earlier today from oej, kpfleming, and russellb, implement ast_channel_search_locked which iterates over the channel list, while locked, and calls a filter callback to determine if this is the channel we are looking for.  If so, we lock and return, otherwise we return NULL.

Patch also includes the change required to chan_sip.c to use the new function.

Diffs (updated)

  /trunk/channels/chan_sip.c 154189 
  /trunk/include/asterisk/channel.h 154189 
  /trunk/main/channel.c 154189 

Diff: http://reviewboard.digium.com/r/28/diff




More information about the asterisk-dev mailing list