[asterisk-dev] [Code Review] Implement ast_channel_search_locked to expensive per-notify channel walk in chan_sip

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/28/#review69
-----------------------------------------------------------



/trunk/include/asterisk/channel.h
<http://reviewboard.digium.com/r/28/#comment121>

    Also, let's call it the "channel_match" function or something instead of "filter" to better match its purpose.


- Russell


On 2008-11-04 16:27:50, Sean Bright wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/28/
> -----------------------------------------------------------
> 
> (Updated 2008-11-04 16:27:50)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Based on some feedback from my chan_sip commit earlier today from oej, kpfleming, and russellb, implement ast_channel_search_locked which iterates over the channel list, while locked, and calls a filter callback to determine if this is the channel we are looking for.  If so, we lock and return, otherwise we return NULL.
> 
> Patch also includes the change required to chan_sip.c to use the new function.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 154189 
>   /trunk/include/asterisk/channel.h 154189 
>   /trunk/main/channel.c 154189 
> 
> Diff: http://reviewboard.digium.com/r/28/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sean
> 
>