[asterisk-dev] Time for a bug fix phase?

[Grey Man]

On Fri, May 30, 2008 at 3:16 PM, Steve Davies <davies147 at gmail.com> wrote:
>
> If you change the format too much, everyone is going to have to
>
> a) Rewrite all of their CDR parsers
> b) Find some way to migrate historical customer data
>
> I am all for moving forwards, but do please keep in mind that lots of
> effort will need to be put into it AFTER the code is changed, so
> please consider a migration path.
>

I agree with that and I don't think many people if any want to see the
CDR format changed. The problem, at least in the case of transfers, is
that a CDR is missing not that the format needs to be changed.

I don't think the fix for this is that difficult. In res_features.c in
ast_bridge_call there is actually a block of code that takes the two
CDR's for the channels on either end of the call and merges them
together to create a new CDR and at the same time deletes the CDRs for
each individual channel. This is the root of the whole problem. The
single merged (bridge) CDR is never going to be able to accurately
record the call details if there are one or more changes on the
channels making up the bridge.

I commented out the code that creates the merged CDR and deletes the
channel CDRs and the results end up being closer to what is required
for the blind and attended transfer calls!

Regards,

Greyman.