[asterisk-dev] [svn-commits] tilghman: trunk r116694 - in /trunk/include/asterisk: strings.h utils.h

[Tzafrir Cohen]

On Mon, May 19, 2008 at 12:43:34PM -0500, Russell Bryant wrote:
> Tilghman Lesher wrote:
> > Index: include/asterisk/strings.h
> > ===================================================================
> > --- include/asterisk/strings.h  (revision 116694)
> > +++ include/asterisk/strings.h  (working copy)
> > @@ -36,9 +36,7 @@
> >         if (!s || (*s == '\0')) {
> >                 return 1;
> >         }
> > -       if (!strcmp(s, "(null)")) {
> > -               ast_log(__LOG_WARNING, file, line, function, "Possible 
> > programming error: \"(null)\" is not NULL!\n");
> > -       }
> > +       _ast_assert(strcmp(s, "(null)"), "strcmp(s, \"(null)\")", file, line, 
> > function);
> >         return 0;
> >  }
> 
> You're right.  That's the best you can do with an inline function that lives in 
> a header file.  This is fine with me.

Why not a macro, then?

-- 
               Tzafrir Cohen
icq#16849755              jabber:tzafrir.cohen at xorcom.com
+972-50-7952406           mailto:tzafrir.cohen at xorcom.com
http://www.xorcom.com  iax:guest at local.xorcom.com/tzafrir