[asterisk-dev] [svn-commits] tilghman: trunk r116694 - in /trunk/include/asterisk: strings.h utils.h

Russell Bryant russell at digium.com
Mon May 19 12:43:34 CDT 2008


Tilghman Lesher wrote:
> Index: include/asterisk/strings.h
> ===================================================================
> --- include/asterisk/strings.h  (revision 116694)
> +++ include/asterisk/strings.h  (working copy)
> @@ -36,9 +36,7 @@
>         if (!s || (*s == '\0')) {
>                 return 1;
>         }
> -       if (!strcmp(s, "(null)")) {
> -               ast_log(__LOG_WARNING, file, line, function, "Possible 
> programming error: \"(null)\" is not NULL!\n");
> -       }
> +       _ast_assert(strcmp(s, "(null)"), "strcmp(s, \"(null)\")", file, line, 
> function);
>         return 0;
>  }

You're right.  That's the best you can do with an inline function that lives in 
a header file.  This is fine with me.

Thanks,

-- 
Russell Bryant
Senior Software Engineer
Open Source Team Lead
Digium, Inc.



More information about the asterisk-dev mailing list