[asterisk-dev] zaptel/libpri 1.4 Makefile: test for id = 0

[Tzafrir Cohen]

On Mon, May 12, 2008 at 05:55:21PM +0300, Tzafrir Cohen wrote:
> On Mon, May 12, 2008 at 04:31:24PM +0200, Patrick wrote:
> > Hi,
> > 
> > Would the developers please consider adding a test for id = 0 to a
> > couple of lines in the Makefiles of zaptel & libpri 1.4. This test is
> > already done at a couple of places in the Makefiles. Before executing
> > ldconfig for example (but not everywhere). Here are the occurrences
> > where the test for id = 0 would be appreciated:
> 
> What happens when you run the build under fakeroot?

The point is that Debian builds that package with fakeroot which returns
id 0 (handy for producing a decent tarball and such). But fakeroot is
still not good enough a fake to allow you to run ldconfig .

Hence "more of the same would also be needed for the case where id == 0 .
At least for ldconfig . Probably also for restorecon (fakeroot and
selinux? yeah, there are those who use both).

> 
> > 
> > zaptel 1.4.10.1, Makefile, line 478
> > 
> > 	/sbin/restorecon -v $(DESTDIR)$(LIB_DIR)/$(LTZ_SO)
> > 
> > 
> > libpri 1.4.4, Makefile, line 104:
> > 
> > 	if [ -x /usr/sbin/sestatus ] && ( /usr/sbin/sestatus | grep "SELinux
> > status:" | grep -q "enabled"); then /sbin/restorecon -v
> > $(INSTALL_PREFIX)$(INSTALL_BASE)/lib/$(DYNAMIC_LIBRARY); fi
> > 
> > 
> > libpri 1.4.4, Makefile, line 147
> > 
> > 	$(LDCONFIG) $(LDCONFIG_FLAGS) .

-- 
               Tzafrir Cohen
icq#16849755              jabber:tzafrir.cohen at xorcom.com
+972-50-7952406           mailto:tzafrir.cohen at xorcom.com
http://www.xorcom.com  iax:guest at local.xorcom.com/tzafrir